Conversation
3u13r
suggested changes
Dec 18, 2024
msanft
reviewed
Jan 3, 2025
katexochen
reviewed
Feb 6, 2025
katexochen
reviewed
Feb 6, 2025
thomasten
reviewed
Feb 7, 2025
burgerdev
commented
Feb 11, 2025
msanft
reviewed
Feb 11, 2025
msanft
approved these changes
Feb 12, 2025
Member
msanft
left a comment
msanft
left a comment
There was a problem hiding this comment.
Thanks for writing this up so thoroughly and well-explained!
To the best of my (arguably limited) knowledge on this part of Contrast, this looks good.
thomasten
approved these changes
Feb 12, 2025
Member
thomasten
left a comment
thomasten
left a comment
There was a problem hiding this comment.
Thanks, looks solid to me! (modulo my incomplete knowledge on some Contrast details)
nit: there are still some mentions of RFC009 in the text
katexochen
approved these changes
Feb 12, 2025
Co-authored-by: Thomas Tendyck <[email protected]> Co-authored-by: 3u13r <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.